RESOLVED FIXED151366
[JSC] Add an empty FTLOutput for B3 that crashes on any operation 
https://bugs.webkit.org/show_bug.cgi?id=151366
Summary [JSC] Add an empty FTLOutput for B3 that crashes on any operation
Benjamin Poulain
Reported 2015-11-17 15:29:08 PST
[JSC] Add an empty FTLOutput for B3 that crashes on any operation
Attachments
Patch (22.98 KB, patch)
2015-11-17 15:29 PST, Benjamin Poulain 		fpizlo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2015-11-17 15:29:41 PST
Created attachment 265712 [details] Patch
WebKit Commit Bot
Comment 2 2015-11-17 15:31:46 PST
Attachment 265712 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/ftl/B3Output.h:315: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/ftl/FTLOutput.cpp:28: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/JavaScriptCore/ftl/FTLAbstractHeap.cpp:31: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/JavaScriptCore/ftl/FTLAbbreviatedTypes.h:31: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/JavaScriptCore/ftl/FTLAbbreviatedTypes.h:33: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 5 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Pizlo
Comment 3 2015-11-17 15:36:03 PST
Comment on attachment 265712 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=265712&action=review > Source/JavaScriptCore/ChangeLog:9 > + * ftl/B3Output.h: Added. The only thing I don't love is the filename. How about FTLB3Output.h?
Benjamin Poulain
Comment 4 2015-11-17 15:44:02 PST
Committed r192546: <http://trac.webkit.org/changeset/192546>
Note You need to log in before you can comment on or make changes to this bug.