Bug 90210 (BeverlyHills)

Summary: [Chromium] On Android, we should be able to ask the embedder what intents exist in a region of the page
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, fishd, jamesr, japhet, leandrogracia, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 66687    
Attachments:
Description Flags
Patch
none
Patch for landing none

Adam Barth
Reported 2012-06-28 14:34:24 PDT
[Chromium] On Android, we should be able to ask the embedder what intents exist in a region of the page
Attachments
Patch (5.90 KB, patch)
2012-06-28 14:40 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch for landing (6.10 KB, patch)
2012-06-28 15:34 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-06-28 14:40:33 PDT
Created attachment 150016 [details] Patch
WebKit Review Bot
Comment 2 2012-06-28 14:43:53 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Leandro Graciá Gil
Comment 3 2012-06-28 14:53:35 PDT
lgtm.
Dimitri Glazkov (Google)
Comment 4 2012-06-28 15:25:15 PDT
Comment on attachment 150016 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=150016&action=review > Source/WebKit/chromium/public/WebViewClient.h:375 > + virtual WebContentDetectionResult detechContentAround(const WebHitTestResult&) { return WebContentDetectionResult(); } detech -> detect?
Adam Barth
Comment 5 2012-06-28 15:32:21 PDT
(In reply to comment #4) > (From update of attachment 150016 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=150016&action=review > > > Source/WebKit/chromium/public/WebViewClient.h:375 > > + virtual WebContentDetectionResult detechContentAround(const WebHitTestResult&) { return WebContentDetectionResult(); } > > detech -> detect? Yep. Thanks!
Adam Barth
Comment 6 2012-06-28 15:34:43 PDT
Created attachment 150028 [details] Patch for landing
Adam Barth
Comment 7 2012-06-28 16:20:55 PDT
Comment on attachment 150028 [details] Patch for landing Clearing flags on attachment: 150028 Committed r121483: <http://trac.webkit.org/changeset/121483>
Adam Barth
Comment 8 2012-06-28 16:20:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.