Bug 89721

Summary: [Chromium] DumpRenderTree on Android needs to configure fonts for testing
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: dpranke, japhet, jnd, ojan, peter, tkent, webkit.review.bot, zhenghao
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 66687    
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing
none
Patch for landing none

Adam Barth
Reported 2012-06-21 17:43:20 PDT
[Chromium] DumpRenderTree on Android needs to configure fonts for testing
Attachments
Patch (6.83 KB, patch)
2012-06-21 17:46 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (10.36 KB, patch)
2012-06-21 18:21 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch for landing (10.46 KB, patch)
2012-06-22 11:08 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch for landing (10.53 KB, patch)
2012-06-22 19:00 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-06-21 17:46:18 PDT
Created attachment 148923 [details] Patch
Adam Barth
Comment 2 2012-06-21 18:18:45 PDT
Comment on attachment 148923 [details] Patch Missed a couple.
Adam Barth
Comment 3 2012-06-21 18:21:19 PDT
Created attachment 148934 [details] Patch
Peter Beverloo
Comment 4 2012-06-22 08:17:27 PDT
Comment on attachment 148934 [details] Patch LGTM for the WebKit side, but please do not commit this until the SkUseTestFontConfigFile API has landed in Skia and has rolled to Chromium, then to WebKit, none of which is the case as of yet.
Adam Barth
Comment 5 2012-06-22 10:08:37 PDT
Peter, is there a bug I can track to see when that happens?
Adam Barth
Comment 6 2012-06-22 11:05:25 PDT
I'm tempted to land this with the call to SkUseTestFontConfigFile commented out until the API is available.
Nate Chapin
Comment 7 2012-06-22 11:06:37 PDT
(In reply to comment #6) > I'm tempted to land this with the call to SkUseTestFontConfigFile commented out until the API is available. What sort of time scale are we looking at for SkUseTestFontConfigFile to become available?
Adam Barth
Comment 8 2012-06-22 11:08:39 PDT
Created attachment 149063 [details] Patch for landing
Adam Barth
Comment 9 2012-06-22 11:15:35 PDT
> What sort of time scale are we looking at for SkUseTestFontConfigFile to become available? Looks like the chromium-android branch has a 79 line diff to Skia, of which this change accounts for all but 7. Maybe we should try contributing that patch to Skia ourselves? It's all in Android-specific files.
Adam Barth
Comment 10 2012-06-22 16:54:47 PDT
Comment on attachment 149063 [details] Patch for landing I think it's ok to land this patch with the call to SkUseTestFontConfigFile commented out. We're going to drive the Skia side of this change to completion, so we might as well have this code upstream.
Peter Beverloo
Comment 11 2012-06-22 18:43:26 PDT
Agreed, though I'd prefer to attach a bug to the FIXME so it's easier to keep track of. Not that I have any doubt about you following up, of course :).
Adam Barth
Comment 12 2012-06-22 18:52:29 PDT
I filed Bug 89801 about this topic.
Adam Barth
Comment 13 2012-06-22 19:00:47 PDT
Created attachment 149155 [details] Patch for landing
WebKit Review Bot
Comment 14 2012-06-22 19:33:06 PDT
Comment on attachment 149155 [details] Patch for landing Clearing flags on attachment: 149155 Committed r121086: <http://trac.webkit.org/changeset/121086>
WebKit Review Bot
Comment 15 2012-06-22 19:33:12 PDT
All reviewed patches have been landed. Closing bug.
Adam Barth
Comment 16 2012-06-24 01:33:15 PDT
*** Bug 87006 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.