Bug 87641

Summary: [Shadow DOM] Add an assertion to make sure that an inaccessible node is not set to event's target or relatedTarget in event dispatching
Product: WebKit Reporter: Hayato Ito <hayato>
Component: DOMAssignee: Hayato Ito <hayato>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, dominicc, morrita, shinyak, tasak, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 59805    
Attachments:
Description Flags
add assertions
none
Patch for landing none

Hayato Ito
Reported 2012-05-28 02:12:52 PDT
We should have an assertion to make sure that an inaccessible node is not set to event's target or relatedTarget in event dispatching.
Attachments
add assertions (2.86 KB, patch)
2012-05-28 05:06 PDT, Hayato Ito 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.91 KB, patch)
2012-05-29 19:07 PDT, Hayato Ito 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Hayato Ito
Comment 1 2012-05-28 05:06:27 PDT
Created attachment 144335 [details] add assertions
Dimitri Glazkov (Google)
Comment 2 2012-05-29 09:44:31 PDT
Comment on attachment 144335 [details] add assertions View in context: https://bugs.webkit.org/attachment.cgi?id=144335&action=review > Source/WebCore/dom/EventContext.h:52 > + bool accessible(Node*); Might as well not compile it in NDEBUG.
Hayato Ito
Comment 3 2012-05-29 18:45:37 PDT
Thank you for the review. (In reply to comment #2) > (From update of attachment 144335 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=144335&action=review > > > Source/WebCore/dom/EventContext.h:52 > > + bool accessible(Node*); > > Might as well not compile it in NDEBUG. Okay. I'll guard it using NDEBUG. Let me land this patch after that.
Hayato Ito
Comment 4 2012-05-29 19:07:30 PDT
Created attachment 144676 [details] Patch for landing
WebKit Review Bot
Comment 5 2012-05-29 21:06:09 PDT
Comment on attachment 144676 [details] Patch for landing Clearing flags on attachment: 144676 Committed r118889: <http://trac.webkit.org/changeset/118889>
WebKit Review Bot
Comment 6 2012-05-29 21:06:14 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.