Bug 52695

Summary: WK2 - Multiple crashes in PlatformCALayer::replaceSublayer
Product: WebKit Reporter: Chris Marrin <cmarrin>
Component: Layout and RenderingAssignee: Chris Marrin <cmarrin>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, andersca, eric, simon.fraser, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.6   
Attachments:
Description Flags
Patch simon.fraser: review+

Chris Marrin
Reported 2011-01-18 18:49:49 PST
In WK2 making the window > 2000 pixels wide (or high) crashes because we are trying to switch the root layer to be tiled. Since it has no superlayer, there is no way to reattach it, so we crash. In radar 8751147
Attachments
Patch (8.17 KB, patch)
2011-01-18 18:56 PST, Chris Marrin 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Marrin
Comment 1 2011-01-18 18:56:28 PST
Created attachment 79382 [details] Patch
Simon Fraser (smfr)
Comment 2 2011-01-18 20:19:46 PST
Comment on attachment 79382 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=79382&action=review > Source/WebKit2/ChangeLog:13 > + Added a hostingLayer as the parent of the existing drawingLayer. > + The hostingLayer is now the root which is passed to the > + remote context. It never changes except to track the size > + of the window. The drawingLayer is now a child of the > + hostingLayer, which allow it to switch between tiled and > + non-tiled. s/drawingLayer/backingLayer > Source/WebKit2/ChangeLog:15 > + I also not give back accurate settings for debug borders and s/not/now
Anders Carlsson
Comment 3 2011-01-19 11:27:02 PST
Committed r76143: <http://trac.webkit.org/changeset/76143>
WebKit Review Bot
Comment 4 2011-01-19 12:03:40 PST
http://trac.webkit.org/changeset/76143 might have broken SnowLeopard Intel Release (Tests)
Note You need to log in before you can comment on or make changes to this bug.