Bug 273315
| Summary: | [CMake] Skia headers symlink is sometimes not created before it is needed | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Adrian Perez <aperez> |
| Component: | Tools / Tests | Assignee: | Adrian Perez <aperez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Local Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=270776 | ||
Adrian Perez
Building .o files does not need libSkia.a, and the headers symlink is created
as side effect of generating libSkia.a; so we can end up in situations where
sources need to include the Skia headers but the symlink wasn't yet created.
For example in this build log:
https://ews-build.webkit.org/#/builders/5/builds/52139/steps/14/logs/stdio
This is more obvious after bug #270776 but could have happened before that,
we were just lucky that as a custom_target() without dependencies Ninja/Make
were scheduling symlink creation very early during the build.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Adrian Perez
Pull request: https://github.com/WebKit/WebKit/pull/27797
EWS
Committed 278034@main (6f3cd5542cb2): <https://commits.webkit.org/278034@main>
Reviewed commits have been landed. Closing PR #27797 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/127109036>