Bug 237397

Created attachment 453675 [details] Patch v1.0

Comment on attachment 453675 [details] Patch v1.0 View in context: https://bugs.webkit.org/attachment.cgi?id=453675&action=review > Source/WebInspectorUI/ChangeLog:19 > + This wasn't the case for the first recording's `CPUTimelineView because it is already attached when it performs If this is not a problem for `initialLayout`, then how does the `TimelineRuler` have bad values after that if the user hasn't navigated away from the `CPUTimelineView`? This makes it sound like reloading the page somehow `detach` and then re-`attach` the `CPUTimelineView`. I would hope that we're not doing that for a simple page reload. > Source/WebInspectorUI/UserInterface/Views/View.js:37 > + this._dirtyFromResize = false; Rather than adding another property, maybe we make `_layoutReason` into a `Set` (or bitmap if we're concerned about memory) so that if more `WI.View.LayoutReason` are added (or custom ones like `WI.CPUTimelineView.LayoutReason.Internal` are used more frequently) then we don't have to add even more properties. I think there's only a dozen or so uses of `this.layoutReason === ...` anyways, so changing those to `this.layoutReasons.has(...)` (or `this.layoutReasons & ...`) would probably be pretty simple. Though we'd also probably wanna allow anything that previously only accepted a `layoutReason` to now accept a `layoutReasons` (i.e. `Set`) too.