Bug 209208

Summary: Remove unneeded and incorrect respondsToSelector check.
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, thorton
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Megan Gardner
Reported 2020-03-17 18:41:39 PDT
Remove unneeded and incorrect respondsToSelector check.
Attachments
Patch (2.82 KB, patch)
2020-03-17 18:42 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch (6.57 KB, patch)
2020-03-17 19:39 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch (6.65 KB, patch)
2020-03-18 09:11 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Megan Gardner
Comment 1 2020-03-17 18:42:41 PDT
Created attachment 393807 [details] Patch
Tim Horton
Comment 2 2020-03-17 18:55:01 PDT
Comment on attachment 393807 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393807&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:8703 > return NO; You should remove this extra return NO. Also, there's another similar respondsToSelector check nearby that can be removed
Tim Horton
Comment 3 2020-03-17 18:59:10 PDT
Comment on attachment 393807 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393807&action=review >> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:8703 >> return NO; > > You should remove this extra return NO. > > Also, there's another similar respondsToSelector check nearby that can be removed Actually, maybe this method doesn't need a return value anymore? Does that perhaps simplify the calling code too? That might be nice.
Megan Gardner
Comment 4 2020-03-17 19:39:57 PDT
Created attachment 393815 [details] Patch
Megan Gardner
Comment 5 2020-03-18 09:11:58 PDT
Created attachment 393867 [details] Patch
Megan Gardner
Comment 6 2020-03-18 10:34:13 PDT
<rdar://problem/60512470>
WebKit Commit Bot
Comment 7 2020-03-18 11:15:48 PDT
Comment on attachment 393867 [details] Patch Clearing flags on attachment: 393867 Committed r258653: <https://trac.webkit.org/changeset/258653>
WebKit Commit Bot
Comment 8 2020-03-18 11:15:50 PDT
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 9 2020-03-18 12:05:37 PDT
One small probably-unimportant pedantic question: if these were incorrect, why is there no behavior change?
Tim Horton
Comment 10 2020-03-18 12:19:34 PDT
(In reply to Darin Adler from comment #9) > One small probably-unimportant pedantic question: if these were incorrect, > why is there no behavior change? Because the selector it checked and the selector we used happened to be introduced at the same time :)
Note You need to log in before you can comment on or make changes to this bug.