Bug 189014

Summary: [WHLSL] The parser is too slow
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: WebGPUAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, fpizlo, rmorisset, saam, tdenney, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 176199, 189202    
Attachments:
Description Flags
WIP
none
first draft
none
Second draft
none
Removes try/catch
none
Patch
none
Patch
none
Patch none

Myles C. Maxfield
Reported 2018-08-27 15:18:46 PDT
It takes 2.5 hours to compile the standard library. 95% of the time is spent parsing.
Attachments
WIP (32.18 KB, patch)
2018-09-04 19:41 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
first draft (60.82 KB, patch)
2018-09-05 11:42 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Second draft (51.31 KB, patch)
2018-09-05 13:06 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Removes try/catch (54.33 KB, patch)
2018-09-05 15:12 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (62.09 KB, patch)
2018-09-05 17:27 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (63.37 KB, patch)
2018-09-05 19:00 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (63.37 KB, patch)
2018-09-05 19:10 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2018-08-27 15:21:28 PDT
*** This bug has been marked as a duplicate of bug 188517 ***
Myles C. Maxfield
Comment 2 2018-08-28 15:54:30 PDT
Reopening
Myles C. Maxfield
Comment 3 2018-09-04 19:41:52 PDT
Created attachment 348887 [details] WIP
Myles C. Maxfield
Comment 4 2018-09-05 11:42:55 PDT
Created attachment 348951 [details] first draft
Myles C. Maxfield
Comment 5 2018-09-05 13:06:32 PDT
Created attachment 348955 [details] Second draft
Myles C. Maxfield
Comment 6 2018-09-05 15:12:22 PDT
Created attachment 348970 [details] Removes try/catch
Myles C. Maxfield
Comment 7 2018-09-05 17:27:41 PDT
Created attachment 348985 [details] Patch
Thomas Denney
Comment 8 2018-09-05 17:34:54 PDT
Comment on attachment 348985 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348985&action=review > Tools/WebGPUShadingLanguageRI/Lexer.js:45 > +     } Weird characters here.
Myles C. Maxfield
Comment 9 2018-09-05 19:00:45 PDT
Created attachment 348993 [details] Patch
Myles C. Maxfield
Comment 10 2018-09-05 19:10:37 PDT
Created attachment 348994 [details] Patch
WebKit Commit Bot
Comment 11 2018-09-06 09:01:13 PDT
Comment on attachment 348994 [details] Patch Clearing flags on attachment: 348994 Committed r235738: <https://trac.webkit.org/changeset/235738>
WebKit Commit Bot
Comment 12 2018-09-06 09:01:14 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 13 2018-09-06 09:03:27 PDT
<rdar://problem/44183440>
Myles C. Maxfield
Comment 14 2018-10-13 15:20:47 PDT
Migrated to https://github.com/gpuweb/WHLSL/issues/87
Note You need to log in before you can comment on or make changes to this bug.