Bug 174434

Summary: REGRESSION(r219361): Huge PLUM memory regression on iOS (Requested by kling on #webkit).
Product: WebKit Reporter: WebKit Commit Bot <commit-queue>
Component: New BugsAssignee: WebKit Commit Bot <commit-queue>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, kling, sam
Priority: P2 Keywords: InRadar, Performance, Regression
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 174140    
Attachments:
Description Flags
ROLLOUT of r219361 none

WebKit Commit Bot
Reported 2017-07-12 13:39:46 PDT
http://trac.webkit.org/changeset/219361 broke the build: Huge PLUM memory regression on iOS (Requested by kling on #webkit). This is an automatic bug report generated by webkitbot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests fail.
Attachments
ROLLOUT of r219361 (72.34 KB, patch)
2017-07-12 13:39 PDT, WebKit Commit Bot 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
WebKit Commit Bot
Comment 1 2017-07-12 13:39:59 PDT
Created attachment 315279 [details] ROLLOUT of r219361 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment.
Andreas Kling
Comment 2 2017-07-12 13:40:21 PDT
<rdar://problem/33265549>
WebKit Commit Bot
Comment 3 2017-07-12 13:43:41 PDT
Comment on attachment 315279 [details] ROLLOUT of r219361 Clearing flags on attachment: 315279 Committed r219421: <http://trac.webkit.org/changeset/219421>
WebKit Commit Bot
Comment 4 2017-07-12 13:43:42 PDT
All reviewed patches have been landed. Closing bug.
Sam Weinig
Comment 5 2017-07-12 13:47:22 PDT
Do you have any data I can look at to understand what the regression was?
Andreas Kling
Comment 6 2017-07-12 13:56:22 PDT
(In reply to Sam Weinig from comment #5) > Do you have any data I can look at to understand what the regression was? There are some Apple-internal links in the radar: <rdar://problem/33265549> It's not really overflowing with information though. :/ Based on the nature of your patch, my guess would be DOM leak.
Sam Weinig
Comment 7 2017-07-12 16:48:11 PDT
(In reply to Andreas Kling from comment #6) > (In reply to Sam Weinig from comment #5) > > Do you have any data I can look at to understand what the regression was? > > There are some Apple-internal links in the radar: <rdar://problem/33265549> > > It's not really overflowing with information though. :/ > > Based on the nature of your patch, my guess would be DOM leak. Yeah, as soon as I asked, I realized it must be a leak. Sorry :(.
Note You need to log in before you can comment on or make changes to this bug.