Bug 140258

Summary:

[Win] Connect 'addUserScriptToGroup' (and related) calls from WebView API to the WebCore implementation

Product:

WebKit

Reporter:

Brent Fulgham <bfulgham>

Component:

WebKit Misc.

Assignee:

Hyungwook Lee <hyungwook.lee>

Status:

NEW

Severity:

Normal

CC:

andersca, bfulgham, commit-queue, hyungwook.lee, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

OS:

All

Bug Depends on:

145908

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Brent Fulgham

Reported 2015-01-08 11:05:46 PST

The following layout tests are failing on Windows: userscripts/document-element-available-at-start.html userscripts/mixed-case-stylesheet.html userscripts/script-not-run-for-fragments.html userscripts/script-run-at-end.html userscripts/script-run-at-start.html userscripts/simple-stylesheet.html userscripts/user-script-all-frames.html userscripts/user-script-image-document.html userscripts/user-style-all-frames.html userscripts/user-stylesheet-invalidate.html

Attachments
Patch (12.77 KB, patch) 2015-06-29 04:16 PDT, Hyungwook Lee	no flags	Details Formatted Diff Diff
Patch (12.88 KB, patch) 2015-06-29 04:22 PDT, Hyungwook Lee	no flags	Details Formatted Diff Diff
Patch (14.26 KB, patch) 2015-06-30 16:45 PDT, Hyungwook Lee	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Brent Fulgham

Comment 1 2015-01-21 11:20:18 PST

These are falling because none of the 'addUserScriptToGroup' or 'removeUserScriptFromGroup' API calls for WebView are connected to anything.

Radar WebKit Bug Importer

Comment 2 2015-01-21 11:21:28 PST

<rdar://problem/19551137>

Brent Fulgham

Comment 3 2015-01-21 11:27:04 PST

This requires the following: 1. Duplicate WebCoreGroup from mac->win. (Could almost be shared). 2. Connect the implementations in WebView. Not sure if anyone needs this functionality yet.

Hyungwook Lee

Comment 4 2015-06-29 04:16:06 PDT

Created attachment 255741 [details] Patch

WebKit Commit Bot

Comment 5 2015-06-29 04:18:47 PDT

Attachment 255741 [details] did not pass style-queue: ERROR: Source/WebKit/win/WebView.cpp:6460: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/WebView.cpp:6461: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/WebView.cpp:6483: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/WebView.cpp:6484: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/WebView.h:790: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/WebView.h:791: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/WebView.h:794: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/WebView.h:795: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 8 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.

Hyungwook Lee

Comment 6 2015-06-29 04:22:28 PDT

Created attachment 255742 [details] Patch

WebKit Commit Bot

Comment 7 2015-06-29 04:23:44 PDT

Attachment 255742 [details] did not pass style-queue: ERROR: Source/WebKit/win/WebView.cpp:6460: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/WebView.cpp:6461: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/WebView.cpp:6482: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/WebView.cpp:6483: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/WebView.h:790: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/WebView.h:791: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/WebView.h:794: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/WebView.h:795: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 8 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.

Hyungwook Lee

Comment 8 2015-06-29 04:26:34 PDT

(In reply to comment #7) > Attachment 255742 [details] did not pass style-queue: > > > ERROR: Source/WebKit/win/WebView.cpp:6460: Weird number of spaces at > line-start. Are you using a 4-space indent? [whitespace/indent] [3] > ERROR: Source/WebKit/win/WebView.cpp:6461: Weird number of spaces at > line-start. Are you using a 4-space indent? [whitespace/indent] [3] > ERROR: Source/WebKit/win/WebView.cpp:6482: Weird number of spaces at > line-start. Are you using a 4-space indent? [whitespace/indent] [3] > ERROR: Source/WebKit/win/WebView.cpp:6483: Weird number of spaces at > line-start. Are you using a 4-space indent? [whitespace/indent] [3] > ERROR: Source/WebKit/win/WebView.h:790: Weird number of spaces at > line-start. Are you using a 4-space indent? [whitespace/indent] [3] > ERROR: Source/WebKit/win/WebView.h:791: Weird number of spaces at > line-start. Are you using a 4-space indent? [whitespace/indent] [3] > ERROR: Source/WebKit/win/WebView.h:794: Weird number of spaces at > line-start. Are you using a 4-space indent? [whitespace/indent] [3] > ERROR: Source/WebKit/win/WebView.h:795: Weird number of spaces at > line-start. Are you using a 4-space indent? [whitespace/indent] [3] > Total errors found: 8 in 6 files > > > If any of these errors are false positives, please file a bug against > check-webkit-style. This style errors comes to meet previous parameter's position that looks not meet current webkit style.

Anders Carlsson

Comment 9 2015-06-30 14:04:09 PDT

I think it'd be better to just skip the tests on Windows than adding more page group level things.

Hyungwook Lee

Comment 10 2015-06-30 16:45:52 PDT

Created attachment 255875 [details] Patch

Hyungwook Lee

Comment 11 2015-06-30 16:46:09 PDT

(In reply to comment #9) > I think it'd be better to just skip the tests on Windows than adding more > page group level things. Done

WebKit Commit Bot

Comment 12 2015-06-30 16:48:20 PDT

Attachment 255875 [details] did not pass style-queue: ERROR: Source/WebKit/win/WebView.cpp:6460: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/WebView.cpp:6461: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/WebView.cpp:6482: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/WebView.cpp:6483: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/WebView.h:790: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/WebView.h:791: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/WebView.h:794: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/WebView.h:795: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 8 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.

Anders Carlsson

Comment 13 2015-07-01 07:41:52 PDT

(In reply to comment #11) > (In reply to comment #9) > > I think it'd be better to just skip the tests on Windows than adding more > > page group level things. > > Done I mean, skip the tests and not implement any WebKit API on Windows :) Unless there's a legitimate need for this on Windows, adding more unused code just for the sake of adding code is a bad idea.

Hyungwook Lee

Comment 14 2015-07-01 20:17:36 PDT

(In reply to comment #13) > (In reply to comment #11) > > (In reply to comment #9) > > > I think it'd be better to just skip the tests on Windows than adding more > > > page group level things. > > > > Done > > I mean, skip the tests and not implement any WebKit API on Windows :) Unless > there's a legitimate need for this on Windows, adding more unused code just > for the sake of adding code is a bad idea. I agreed with you that adding unused code is not good idea. I will hold this patch until we have legitimate needs for Windows port.

Brent Fulgham

Comment 15 2015-08-13 09:33:19 PDT

Comment on attachment 255875 [details] Patch Removing review flag on this patch so it doesn't show up in the current request queue. Please re-flag for review when we decide we want to pursue this feature.

Note You need to log in before you can comment on or make changes to this bug.