Bug 138096

Summary: Devirtualize RenderDeprecatedFlexibleBox::isStretchingChildren().
Product: WebKit Reporter: Andreas Kling <kling>
Component: Layout and RenderingAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kling, kondapallykalyan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch cdumez: review+

Andreas Kling
Reported 2014-10-27 10:46:22 PDT
Small patch inc.
Attachments
Patch (3.54 KB, patch)
2014-10-27 10:47 PDT, Andreas Kling 		cdumez: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2014-10-27 10:47:34 PDT
Created attachment 240487 [details] Patch
Chris Dumez
Comment 2 2014-10-27 10:48:48 PDT
Comment on attachment 240487 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240487&action=review r=me with nit. > Source/WebCore/rendering/RenderBox.cpp:2702 > if (h.isAuto() && parent()->isDeprecatedFlexibleBox() && parent()->style().boxOrient() == HORIZONTAL nit: is<RenderDeprecatedFlexibleBox>(*parent())
WebKit Commit Bot
Comment 3 2014-10-27 10:50:22 PDT
Attachment 240487 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/RenderBox.cpp:2703: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andreas Kling
Comment 4 2014-10-27 13:42:43 PDT
Committed r175230: <http://trac.webkit.org/changeset/175230>
Note You need to log in before you can comment on or make changes to this bug.