Bug 112144

Created attachment 192739 [details] Patch

Just realized that this doesn't work quite right yet because the thisObject will be wrong. Working on a solution :)

Comment on attachment 192739 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=192739&action=review > Tools/ChangeLog:16 > + This is impplemented by instantiating the QObject based testRunner in > + the global object, then instantiating the JSC C based TestRunner > + separately and placing it "behind" the QObject based testRunner through > + injection in the prototype chain. This allows for porting over method > + by method by removing the method from the QObject TestRunnerQt and > + implementing it in the JSC C based TestRunner. Good idea! > Tools/DumpRenderTree/qt/TestRunnerQt.cpp:982 > + > + > + > +void TestRunner::notifyDone() many spaces? > Tools/DumpRenderTree/qt/TestRunnerQt.cpp:1001 > +} > + > + > +void TestRunner::removeAllWebNotificationPermissions() Ditto. > Tools/DumpRenderTree/qt/TestRunnerQt.cpp:1010 > +} > + > + > +void TestRunner::closeIdleLocalStorageDatabases() Ditto. > Tools/DumpRenderTree/qt/TestRunnerQt.cpp:1015 > +} > + > + > +void TestRunner::focusWebView() Ditto. > Tools/DumpRenderTree/qt/TestRunnerQt.cpp:1024 > +} > + > + > +void TestRunner::removeChromeInputField() Ditto. > Tools/DumpRenderTree/qt/TestRunnerQt.cpp:1029 > +} > + > + > +void TestRunner::addChromeInputField() Ditto. > Tools/DumpRenderTree/qt/TestRunnerQt.cpp:1034 > +} > + > + > +JSValueRef TestRunner::originsWithLocalStorage(JSContextRef context) Ditto. > Tools/DumpRenderTree/qt/TestRunnerQt.cpp:1048 > + > + > +void TestRunner::observeStorageTrackerNotifications(unsigned number) Ditto. > Tools/DumpRenderTree/qt/TestRunnerQt.cpp:1057 > +} > + > + > +int TestRunner::windowCount() Ditto. > Tools/DumpRenderTree/qt/TestRunnerQt.cpp:1063 > +} > + > + > +void TestRunner::setWaitToDump(bool) Ditto. > Tools/DumpRenderTree/qt/TestRunnerQt.cpp:1068 > + > + > +void TestRunner::waitForPolicyDelegate() Ditto. > Tools/DumpRenderTree/qt/TestRunnerQt.cpp:1078 > +} > + > + > +void TestRunner::showWebInspector() Ditto. > Tools/DumpRenderTree/qt/TestRunnerQt.cpp:1091 > +} > + > + > +void TestRunner::setSerializeHTTPLoads(bool) Ditto. > Tools/DumpRenderTree/qt/TestRunnerQt.cpp:1100 > +} > + > + > +void TestRunner::setCustomPolicyDelegate(bool setDelegate, bool permissive) Ditto. > Tools/DumpRenderTree/qt/TestRunnerQt.cpp:1113 > +} > + > + > +void TestRunner::resetPageVisibility() Ditto. > Tools/DumpRenderTree/qt/TestRunnerQt.cpp:1118 > +} > + > + > +void TestRunner::keepWebHistory() Ditto. > Tools/DumpRenderTree/qt/TestRunnerQt.cpp:1123 > +} > + > + > +void TestRunner::goBack() Ditto. > Tools/DumpRenderTree/qt/TestRunnerQt.cpp:1138 > +} > + > + > +void TestRunner::display() Ditto. > Tools/DumpRenderTree/qt/TestRunnerQt.cpp:1143 > +} > + > + > +void TestRunner::dispatchPendingLoadRequests() Ditto. > Tools/DumpRenderTree/qt/TestRunnerQt.cpp:1148 > +} > + > + > +void TestRunner::clearPersistentUserStyleSheet() Ditto. > Tools/DumpRenderTree/qt/TestRunnerQt.cpp:1163 > +} > + > + > +void TestRunner::clearBackForwardList() Ditto. > Tools/DumpRenderTree/qt/TestRunnerQt.cpp:1168 > +} > + > + > +void TestRunner::clearAllDatabases() Ditto. > Tools/DumpRenderTree/qt/TestRunnerQt.cpp:1177 > +} > + > + > +void TestRunner::apiTestGoToCurrentBackForwardItem() Ditto. > Tools/DumpRenderTree/qt/TestRunnerQt.cpp:1186 > +} > + > + > +void TestRunner::abortModal() Ditto. Etc, etc.

Committed r145708: <http://trac.webkit.org/changeset/145708>

(In reply to comment #4) > Committed r145708: <http://trac.webkit.org/changeset/145708> It broke the Win build: moc_TestRunnerQt.cpp C:\WebKitBuildSlave\Qt5.0.1\include\QtCore/qdatetime.h(123) : warning C4003: not enough actual parameters for macro 'min' C:\WebKitBuildSlave\Qt5.0.1\include\QtCore/qdatetime.h(123) : error C2589: '(' : illegal token on right side of '::' C:\WebKitBuildSlave\Qt5.0.1\include\QtCore/qdatetime.h(123) : error C2059: syntax error : '::'

(In reply to comment #5) > (In reply to comment #4) > > Committed r145708: <http://trac.webkit.org/changeset/145708> > > It broke the Win build: > moc_TestRunnerQt.cpp > C:\WebKitBuildSlave\Qt5.0.1\include\QtCore/qdatetime.h(123) : warning C4003: not enough actual parameters for macro 'min' > C:\WebKitBuildSlave\Qt5.0.1\include\QtCore/qdatetime.h(123) : error C2589: '(' : illegal token on right side of '::' > C:\WebKitBuildSlave\Qt5.0.1\include\QtCore/qdatetime.h(123) : error C2059: syntax error : '::' Oops. Sorry! Prospective fix landed in http://trac.webkit.org/changeset/145747 *crossing fingers*