Attachment #426213 for bug #224665

View Details Raw Unified Return to Bug 224665

| Differences between



2021-04-16  Felipe Erias  <felipeerias@igalia.com>

        Table layout takes overriding height into account
        https://bugs.webkit.org/show_bug.cgi?id=224665

        Reviewed by NOBODY (OOPS!).

        RenderTable::layout applies the overriding height set by the element's parent.

        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::layout):

2021-04-12  BJ Burg  <bburg@apple.com>

        Modernize uses of ConsoleClient

Lines 508-513 void RenderTable::layout() a/Source/WebCore/rendering/RenderTable.cpp_sec1
- a/Source/WebCore/rendering/RenderTable.cpp +7 lines
508	if (logicalHeightLength.isIntrinsic() \|\| (logicalHeightLength.isSpecified() && logicalHeightLength.isPositive()))	508	if (logicalHeightLength.isIntrinsic() \|\| (logicalHeightLength.isSpecified() && logicalHeightLength.isPositive()))
509	computedLogicalHeight = convertStyleLogicalHeightToComputedHeight(logicalHeightLength);	509	computedLogicalHeight = convertStyleLogicalHeightToComputedHeight(logicalHeightLength);
510		510
		511	if (hasOverridingLogicalHeight()) {
		512	LayoutUnit captionLogicalHeight;
		513	for (auto& caption : m_captions)
		514	captionLogicalHeight += caption->logicalHeight() + caption->marginBefore() + caption->marginAfter();
		515	computedLogicalHeight = std::max(computedLogicalHeight, overridingLogicalHeight() - captionLogicalHeight);
		516	}
		517
511	Length logicalMaxHeightLength = style().logicalMaxHeight();	518	Length logicalMaxHeightLength = style().logicalMaxHeight();
512	if (logicalMaxHeightLength.isIntrinsic() \|\| (logicalMaxHeightLength.isSpecified() && !logicalMaxHeightLength.isNegative())) {	519	if (logicalMaxHeightLength.isIntrinsic() \|\| (logicalMaxHeightLength.isSpecified() && !logicalMaxHeightLength.isNegative())) {
513	LayoutUnit computedMaxLogicalHeight = convertStyleLogicalHeightToComputedHeight(logicalMaxHeightLength);	520	LayoutUnit computedMaxLogicalHeight = convertStyleLogicalHeightToComputedHeight(logicalMaxHeightLength);



2021-04-16  Felipe Erias  <felipeerias@igalia.com>

        Table layout takes overriding height into account
        https://bugs.webkit.org/show_bug.cgi?id=224665

        Reviewed by NOBODY (OOPS!).

        * TestExpectations: Removed four tests that now pass.

2021-04-12  Chris Dumez  <cdumez@apple.com>

        webaudio/AudioListener/audiolistener-set-position.html is leaking PannerNodes




# Tables as flex items.
webkit.org/b/221473 imported/w3c/web-platform-tests/css/css-flexbox/table-as-item-fixed-min-width-3.html [ ImageOnlyFailure ]
webkit.org/b/221473 imported/w3c/web-platform-tests/css/css-flexbox/table-as-item-flex-cross-size.html [ ImageOnlyFailure ]
webkit.org/b/221473 imported/w3c/web-platform-tests/css/css-flexbox/table-as-item-percent-width-cell-001.html [ ImageOnlyFailure ]
webkit.org/b/221473 imported/w3c/web-platform-tests/css/css-flexbox/table-as-item-specified-width.html [ ImageOnlyFailure ]
webkit.org/b/221473 imported/w3c/web-platform-tests/css/css-flexbox/table-as-item-stretch-cross-size.html [ ImageOnlyFailure ]
webkit.org/b/221473 imported/w3c/web-platform-tests/css/css-flexbox/table-as-item-inflexible-in-column-1.html [ ImageOnlyFailure ]
webkit.org/b/221473 imported/w3c/web-platform-tests/css/css-flexbox/table-as-item-inflexible-in-column-2.html [ ImageOnlyFailure ]
webkit.org/b/221473 imported/w3c/web-platform-tests/css/css-flexbox/table-as-item-inflexible-in-row-2.html [ ImageOnlyFailure ]
webkit.org/b/221473 imported/w3c/web-platform-tests/css/css-flexbox/table-as-item-narrow-content-2.html [ ImageOnlyFailure ]
webkit.org/b/221473 imported/w3c/web-platform-tests/css/css-flexbox/table-as-item-specified-height.html [ ImageOnlyFailure ]
webkit.org/b/221473 imported/w3c/web-platform-tests/css/css-flexbox/table-as-item-stretch-cross-size-2.html [ ImageOnlyFailure ]
webkit.org/b/221473 imported/w3c/web-platform-tests/css/css-flexbox/table-item-flex-percentage-width.html [ ImageOnlyFailure ]

# SVGs as flex items.

Return to Bug 224665

Lines 3962-3977 webkit.org/b/221472 imported/w3c/web-platform-tests/css/css-flexbox/abspos/flex- a/LayoutTests/TestExpectations_sec1
- a/LayoutTests/TestExpectations -4 lines
3962		3962
3963	# Tables as flex items.	3963	# Tables as flex items.
3964	webkit.org/b/221473 imported/w3c/web-platform-tests/css/css-flexbox/table-as-item-fixed-min-width-3.html [ ImageOnlyFailure ]	3964	webkit.org/b/221473 imported/w3c/web-platform-tests/css/css-flexbox/table-as-item-fixed-min-width-3.html [ ImageOnlyFailure ]
3965	webkit.org/b/221473 imported/w3c/web-platform-tests/css/css-flexbox/table-as-item-flex-cross-size.html [ ImageOnlyFailure ]
3966	webkit.org/b/221473 imported/w3c/web-platform-tests/css/css-flexbox/table-as-item-percent-width-cell-001.html [ ImageOnlyFailure ]	3965	webkit.org/b/221473 imported/w3c/web-platform-tests/css/css-flexbox/table-as-item-percent-width-cell-001.html [ ImageOnlyFailure ]
3967	webkit.org/b/221473 imported/w3c/web-platform-tests/css/css-flexbox/table-as-item-specified-width.html [ ImageOnlyFailure ]	3966	webkit.org/b/221473 imported/w3c/web-platform-tests/css/css-flexbox/table-as-item-specified-width.html [ ImageOnlyFailure ]
3968	webkit.org/b/221473 imported/w3c/web-platform-tests/css/css-flexbox/table-as-item-stretch-cross-size.html [ ImageOnlyFailure ]
3969	webkit.org/b/221473 imported/w3c/web-platform-tests/css/css-flexbox/table-as-item-inflexible-in-column-1.html [ ImageOnlyFailure ]	3967	webkit.org/b/221473 imported/w3c/web-platform-tests/css/css-flexbox/table-as-item-inflexible-in-column-1.html [ ImageOnlyFailure ]
3970	webkit.org/b/221473 imported/w3c/web-platform-tests/css/css-flexbox/table-as-item-inflexible-in-column-2.html [ ImageOnlyFailure ]	3968	webkit.org/b/221473 imported/w3c/web-platform-tests/css/css-flexbox/table-as-item-inflexible-in-column-2.html [ ImageOnlyFailure ]
3971	webkit.org/b/221473 imported/w3c/web-platform-tests/css/css-flexbox/table-as-item-inflexible-in-row-2.html [ ImageOnlyFailure ]	3969	webkit.org/b/221473 imported/w3c/web-platform-tests/css/css-flexbox/table-as-item-inflexible-in-row-2.html [ ImageOnlyFailure ]
3972	webkit.org/b/221473 imported/w3c/web-platform-tests/css/css-flexbox/table-as-item-narrow-content-2.html [ ImageOnlyFailure ]
3973	webkit.org/b/221473 imported/w3c/web-platform-tests/css/css-flexbox/table-as-item-specified-height.html [ ImageOnlyFailure ]	3970	webkit.org/b/221473 imported/w3c/web-platform-tests/css/css-flexbox/table-as-item-specified-height.html [ ImageOnlyFailure ]
3974	webkit.org/b/221473 imported/w3c/web-platform-tests/css/css-flexbox/table-as-item-stretch-cross-size-2.html [ ImageOnlyFailure ]
3975	webkit.org/b/221473 imported/w3c/web-platform-tests/css/css-flexbox/table-item-flex-percentage-width.html [ ImageOnlyFailure ]	3971	webkit.org/b/221473 imported/w3c/web-platform-tests/css/css-flexbox/table-item-flex-percentage-width.html [ ImageOnlyFailure ]
3976		3972
3977	# SVGs as flex items.	3973	# SVGs as flex items.

Lines 1-3 a/Source/WebCore/ChangeLog_sec1
- a/Source/WebCore/ChangeLog +12 lines
		1	2021-04-16 Felipe Erias <felipeerias@igalia.com>
		2
		3	Table layout takes overriding height into account
		4	https://bugs.webkit.org/show_bug.cgi?id=224665
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	RenderTable::layout applies the overriding height set by the element's parent.
		9
		10	* rendering/RenderTable.cpp:
		11	(WebCore::RenderTable::layout):
		12
1	2021-04-12 BJ Burg <bburg@apple.com>	13	2021-04-12 BJ Burg <bburg@apple.com>
2		14
3	Modernize uses of ConsoleClient	15	Modernize uses of ConsoleClient

Lines 1-3 a/LayoutTests/ChangeLog_sec1
- a/LayoutTests/ChangeLog +9 lines
		1	2021-04-16 Felipe Erias <felipeerias@igalia.com>
		2
		3	Table layout takes overriding height into account
		4	https://bugs.webkit.org/show_bug.cgi?id=224665
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	* TestExpectations: Removed four tests that now pass.
		9
1	2021-04-12 Chris Dumez <cdumez@apple.com>	10	2021-04-12 Chris Dumez <cdumez@apple.com>
2		11
3	webaudio/AudioListener/audiolistener-set-position.html is leaking PannerNodes	12	webaudio/AudioListener/audiolistener-set-position.html is leaking PannerNodes