2020-03-20  Devin Rousso  <drousso@apple.com>

        Web Inspector: support editing cookie key/values from inspector

        https://bugs.webkit.org/show_bug.cgi?id=31157

        <rdar://problem/19281523>

        Reviewed by NOBODY (OOPS!).

        * inspector/protocol/Page.json:

        Add a `session` parameter to `Page.Cookie` type and a new `Page.setCookie` command.

        Remove the `size` parameter from `Page.Cookie` as this can be calculated in the frontend.

2020-03-20  Devin Rousso  <drousso@apple.com>

        Web Inspector: support editing cookie key/values from inspector

        https://bugs.webkit.org/show_bug.cgi?id=31157

        <rdar://problem/19281523>

        Reviewed by NOBODY (OOPS!).

        Test: http/tests/inspector/page/setCookie.html

        * inspector/agents/InspectorPageAgent.h:

        * inspector/agents/InspectorPageAgent.cpp:

        (WebCore::buildObjectForCookie):

        (WebCore::parseCookieObject): Added.

        (WebCore::InspectorPageAgent::setCookie): Added.

        * loader/CookieJar.h:

        * loader/CookieJar.cpp:

        (WebCore::CookieJar::setRawCookie): Added.

2020-03-20  Devin Rousso  <drousso@apple.com>

        Web Inspector: support editing cookie key/values from inspector

        https://bugs.webkit.org/show_bug.cgi?id=31157

        <rdar://problem/19281523>

        Reviewed by NOBODY (OOPS!).

        * UserInterface/Models/Cookie.js:

        (WI.Cookie):

        (WI.Cookie.fromPayload):

        (WI.Cookie.parseSetCookieResponseHeader):

        (WI.Cookie.prototype.get session): Added.

        (WI.Cookie.prototype.expirationDate):

        (WI.Cookie.prototype.equals): Added.

        (WI.Cookie.prototype.toProtocol): Added.

        Add `session` value in addition to the existing `expires` value. Create helper methods for

        comparing `WI.Cookie` objects and for using the `WI.Cookie` as a `Page.Cookie` type when

        invoking protocol commands (right now just `Page.setCookie`).

        * UserInterface/Views/CookieStorageContentView.js:

        (WI.CookieStorageContentView):

        (WI.CookieStorageContentView.prototype.get navigationItems):

        (WI.CookieStorageContentView.prototype.tableCellContextMenuClicked):

        (WI.CookieStorageContentView.prototype.willDismissPopover): Added.

        (WI.CookieStorageContentView.prototype.async _willDismissCookiePopover): Added.

        (WI.CookieStorageContentView.prototype._handleSetCookieButtonClick): Added.

        (WI.CookieStorageContentView.prototype._reloadCookies):

        (WI.CookieStorageContentView.prototype._formatCookiePropertyForColumn):

        Add a + navigation item that shows a popover for creating a new cookie. When contextmenu

        clicking on a table row, add an "Edit" item that shows a popover for creating a new cookie

        with the values from the existing cookie, which will "replace" (delete and set) the existing

        cookie upon being dismissed.

        * UserInterface/Views/ResourceCookiesContentView.js:

        (WI.ResourceCookiesContentView.prototype.tablePopulateCell):

        If only use the `expires` value if `session` is not set.

        * UserInterface/Views/CookiePopover.js: Added.

        (WI.CookiePopover):

        (WI.CookiePopover.prototype.get serializedData):

        (WI.CookiePopover.prototype.show.createRow):

        (WI.CookiePopover.prototype.show.createInputRow):

        (WI.CookiePopover.prototype.show):

        (WI.CookiePopover.prototype._presentOverTargetElement):

        (WI.CookiePopover.prototype._defaultExpires):

        (WI.CookiePopover.prototype._parseExpires):

        (WI.CookiePopover.prototype._handleInputKeyDown):

        * UserInterface/Views/CookiePopover.css: Added.

        (.popover .cookie-popover-content):

        (.popover .cookie-popover-content > table):

        (.popover .cookie-popover-content > table > tr > th):

        (.popover .cookie-popover-content > table > tr > td):

        (.popover .cookie-popover-content > table > tr > td > input:matches([type="text"], [type="datetime-local"])):

        (.popover .cookie-popover-content > table > tr > td > input:matches([type="text"], [type="datetime-local"]).invalid):

        (@media (prefers-color-scheme: dark) .popover .cookie-popover-content > table > tr > th):

        Show an  `<input>` (or `<select>`) for each configuration option when creating a cookie.

        Hide the `<input>` for `expires` if the `<input type="checkbox">` for `session` is checked.

        Indicate when the value in the `<input>` for `expires` is not a valid date.

        * UserInterface/Main.html:

        * Localizations/en.lproj/localizedStrings.js:

2020-03-20  Devin Rousso  <drousso@apple.com>

        Web Inspector: support editing cookie key/values from inspector

        https://bugs.webkit.org/show_bug.cgi?id=31157

        <rdar://problem/19281523>

        Reviewed by NOBODY (OOPS!).

        * WebProcess/WebPage/WebCookieJar.h:

        * WebProcess/WebPage/WebCookieJar.cpp:

        (WebKit::WebCookieJar::setRawCookie):

        * NetworkProcess/NetworkConnectionToWebProcess.messages.in:

        * NetworkProcess/NetworkConnectionToWebProcess.h:

        * NetworkProcess/NetworkConnectionToWebProcess.cpp:

        (WebKit::NetworkConnectionToWebProcess::setRawCookie): Added.

        {

            "name": "setCookie",

            "description": "Sets a new browser cookie with the given name, domain, and path.",

            "parameters": [

                { "name": "cookie", "$ref": "Cookie" }

            ]

        },

static Optional<Cookie> parseCookieObject(ErrorString& errorString, const JSON::Object& cookieObject)

{

    Cookie cookie;

    if (!cookieObject.getString("name"_s, cookie.name)) {

        errorString = "Invalid value for key name in given cookie";

        return WTF::nullopt;

    }

    if (!cookieObject.getString("value"_s, cookie.value)) {

        errorString = "Invalid value for key value in given cookie";

        return WTF::nullopt;

    }

    if (!cookieObject.getString("domain"_s, cookie.domain)) {

        errorString = "Invalid value for key domain in given cookie";

        return WTF::nullopt;

    }

    if (!cookieObject.getString("path"_s, cookie.path)) {

        errorString = "Invalid value for key path in given cookie";

        return WTF::nullopt;

    }

    if (!cookieObject.getBoolean("httpOnly"_s, cookie.httpOnly)) {

        errorString = "Invalid value for key httpOnly in given cookie";

        return WTF::nullopt;

    }

    if (!cookieObject.getBoolean("secure"_s, cookie.secure)) {

        errorString = "Invalid value for key secure in given cookie";

        return WTF::nullopt;

    }

    bool validSession = cookieObject.getBoolean("session"_s, cookie.session);

    cookie.expires = cookieObject.getNumber<double>("expires"_s);

    if (!validSession && !cookie.expires) {

        errorString = "Invalid value for key expires in given cookie";

        return WTF::nullopt;

    }

    String sameSiteString;

    if (!cookieObject.getString("sameSite"_s, sameSiteString)) {

        errorString = "Invalid value for key sameSite in given cookie";

        return WTF::nullopt;

    }

    auto sameSite = Inspector::Protocol::InspectorHelpers::parseEnumValueFromString<Inspector::Protocol::Page::CookieSameSitePolicy>(sameSiteString);

    if (!sameSite) {

        errorString = "Invalid value for key sameSite in given cookie";

        return WTF::nullopt;

    }

    switch (sameSite.value()) {

    case Inspector::Protocol::Page::CookieSameSitePolicy::None:

        cookie.sameSite = Cookie::SameSitePolicy::None;

        break;

    case Inspector::Protocol::Page::CookieSameSitePolicy::Lax:

        cookie.sameSite = Cookie::SameSitePolicy::Lax;

        break;

    case Inspector::Protocol::Page::CookieSameSitePolicy::Strict:

        cookie.sameSite = Cookie::SameSitePolicy::Strict;

        break;

    }

    return cookie;

}

void InspectorPageAgent::setCookie(ErrorString& errorString, const JSON::Object& cookieObject)

{

    auto cookie = parseCookieObject(errorString, cookieObject);

    if (!cookie)

        return;

    for (auto* frame = &m_inspectedPage.mainFrame(); frame; frame = frame->tree().traverseNext()) {

        if (auto* document = frame->document()) {

            if (auto* page = document->page())

                page->cookieJar().setRawCookie(*document, cookie.value());

        }

    }

}

    void setCookie(ErrorString&, const JSON::Object& cookieObject) override;

void CookieJar::setRawCookie(const Document&, const Cookie& cookie)

{

    if (auto* session = m_storageSessionProvider->storageSession())

        session->setCookie(cookie);

    else

        ASSERT_NOT_REACHED();

}

    virtual void setRawCookie(const Document&, const Cookie&);

localizedStrings["Add Cookie"] = "Add Cookie";

    <link rel="stylesheet" href="Views/CookiePopover.css">

    <script src="Views/CookiePopover.js"></script>

        console.assert(!session || typeof session === "boolean");

        let session = false;

    get session() { return this._session; }

        if (this._session)

            return null;

    equals(other)

    {

        return this._type === other.type

            && this._name === other.name

            && this._value === other.value

            && this._header === other.header

            && this._expires?.getTime() === other.expires?.getTime()

            && this._session === other.session

            && this._maxAge === other.maxAge

            && this._path === other.path

            && this._domain === other.domain

            && this._secure === other.secure

            && this._httpOnly === other.httpOnly

            && this._sameSite === other.sameSite;

    }

    toProtocol()

    {

        if (typeof this._name !== "string")

            return null;

        if (typeof this._value !== "string")

            return null;

        if (typeof this._domain !== "string")

            return null;

        if (typeof this._path !== "string")

            return null;

        if (!this._session && !this._expires)

            return null;

        if (!Object.values(WI.Cookie.SameSiteType).includes(this._sameSite))

            return null;

        let json = {

            name: this._name,

            value: this._value,

            domain: this._domain,

            path: this._path,

            expires: this._expires?.getTime(),

            session: this._session,

            httpOnly: !!this._httpOnly,

            secure: !!this._secure,

            sameSite: this._sameSite,

        };

        return json;

    }

/*

 * Copyright (C) 2020 Apple Inc. All rights reserved.

 *

 * Redistribution and use in source and binary forms, with or without

 * modification, are permitted provided that the following conditions

 * are met:

 * 1. Redistributions of source code must retain the above copyright

 *    notice, this list of conditions and the following disclaimer.

 * 2. Redistributions in binary form must reproduce the above copyright

 *    notice, this list of conditions and the following disclaimer in the

 *    documentation and/or other materials provided with the distribution.

 *

 * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''

 * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,

 * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR

 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS

 * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR

 * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF

 * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS

 * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN

 * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)

 * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF

 * THE POSSIBILITY OF SUCH DAMAGE.

 */

.popover .cookie-popover-content {

    max-width: 420px;

    padding: 4px 8px;

}

.popover .cookie-popover-content > table {

    width: 100%;

}

.popover .cookie-popover-content > table > tr > th {

    font-weight: bold;

    text-align: end;

    line-height: 23px;

    vertical-align: top;

    white-space: nowrap;

    color: hsl(0, 0%, 34%);

}

.popover .cookie-popover-content > table > tr > td {

    -webkit-padding-start: 4px;

}

/* FIXME: <https://webkit.org/b/209389> Web Inspector: use native datetime-local picker for changing `expires` value in cookie popover */

.popover .cookie-popover-content > table > tr > td > input:matches([type="text"], [type="datetime-local"]) {

    width: 100%;

    padding: 3px 4px 2px;

    font-family: Menlo, monospace;

    background-color: var(--background-color-code);

    border: 1px solid var(--text-color-quaternary);

    -webkit-appearance: none;

}

.popover .cookie-popover-content > table > tr > td > input:matches([type="text"], [type="datetime-local"]).invalid {

    color: var(--error-text-color);

}

@media (prefers-color-scheme: dark) {

    .popover .cookie-popover-content > table > tr > th {

        color: var(--text-color-secondary);

    }

}

/*

 * Copyright (C) 2020 Apple Inc. All rights reserved.

 *

 * Redistribution and use in source and binary forms, with or without

 * modification, are permitted provided that the following conditions

 * are met:

 * 1. Redistributions of source code must retain the above copyright

 *    notice, this list of conditions and the following disclaimer.

 * 2. Redistributions in binary form must reproduce the above copyright

 *    notice, this list of conditions and the following disclaimer in the

 *    documentation and/or other materials provided with the distribution.

 *

 * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''

 * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,

 * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR

 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS

 * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR

 * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF

 * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS

 * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN

 * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)

 * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF

 * THE POSSIBILITY OF SUCH DAMAGE.

 */

WI.CookiePopover = class CookiePopover extends WI.Popover

{

    constructor(delegate)

    {

        super(delegate);

        this._nameInputElement = null;

        this._valueInputElement = null;

        this._domainInputElement = null;

        this._pathInputElement = null;

        this._sessionCheckboxElement = null;

        this._expiresInputElement = null;

        this._httpOnlyCheckboxElement = null;

        this._secureCheckboxElement = null;

        this._sameSiteSelectElement = null;

        this._serializedDataWhenShown = null;

        this.windowResizeHandler = this._presentOverTargetElement.bind(this);

    }

    // Public

    get serializedData()

    {

        if (!this._targetElement)

            return null;

        let name = this._nameInputElement.value || this._nameInputElement.placeholder;

        if (!name)

            return null;

        let value = this._valueInputElement.value || this._valueInputElement.placeholder;

        if (!value)

            return null;

        let domain = this._domainInputElement.value || this._domainInputElement.placeholder;

        if (!domain)

            return null;

        let path = this._pathInputElement.value || this._pathInputElement.placeholder;

        if (!path)

            return null;

        let session = this._sessionCheckboxElement.checked;

        let expires = this._parseExpires();

        if (!session && isNaN(expires))

            return null;

        // If a full URL is entered in the domain input, parse it to get just the domain.

        try {

            let url = new URL(domain);

            domain = url.hostname;

        } catch { }

        if (!path.startsWith("/"))

            path = "/" + path;

        let data = {

            name,

            value,

            domain,

            path,

            httpOnly: this._httpOnlyCheckboxElement.checked,

            secure: this._secureCheckboxElement.checked,

            sameSite: this._sameSiteSelectElement.value,

        };

        if (session)

            data.session = true;

        else

            data.expires = expires;

        if (JSON.stringify(data) === JSON.stringify(this._serializedDataWhenShown))

            return null;

        return data;

    }

    show(cookie, targetElement, preferredEdges)

    {

        console.assert(!cookie || cookie instanceof WI.Cookie, cookie);

        console.assert(targetElement instanceof Element, targetElement);

        console.assert(Array.isArray(preferredEdges), preferredEdges);

        this._targetElement = targetElement;

        this._preferredEdges = preferredEdges;

        let data = {};

        if (cookie) {

            data.name = cookie.name;

            data.value = cookie.value;

            data.domain = cookie.domain;

            data.path = cookie.path;

            data.expires = (cookie.expires || this._defaultExpires()).toLocaleString();

            data.session = cookie.session;

            data.httpOnly = cookie.httpOnly;

            data.secure = cookie.secure;

            data.sameSite = cookie.sameSite;

        } else {

            let urlComponents = WI.networkManager.mainFrame.mainResource.urlComponents;

            data.name = WI.unlocalizedString("name");

            data.value = WI.unlocalizedString("value");

            data.domain = urlComponents.host;

            data.path = urlComponents.path;

            data.expires = this._defaultExpires().toLocaleString();

            data.session = true;

            data.httpOnly = false;

            data.secure = false;

            data.sameSite = WI.Cookie.SameSiteType.None;

        }

        let popoverContentElement = document.createElement("div");

        popoverContentElement.className = "cookie-popover-content";

        let tableElement = popoverContentElement.appendChild(document.createElement("table"));

        function createRow(id, label, editorElement) {

            id = `cookie-popover-${id}-editor`;

            let rowElement = tableElement.appendChild(document.createElement("tr"));

            let headerElement = rowElement.appendChild(document.createElement("th"));

            let labelElement = headerElement.appendChild(document.createElement("label"));

            labelElement.setAttribute("for", id);

            labelElement.textContent = label;

            let dataElement = rowElement.appendChild(document.createElement("td"));

            editorElement.id = id;

            dataElement.appendChild(editorElement);

            return {rowElement};

        }

        let boundHandleInputKeyDown = this._handleInputKeyDown.bind(this);

        function createInputRow(id, label, type, value) {

            let inputElement = document.createElement("input");

            inputElement.type = type;

            if (type === "checkbox")

                inputElement.checked = value;

            else {

                if (cookie)

                    inputElement.value = value;

                inputElement.placeholder = value;

                inputElement.addEventListener("keydown", boundHandleInputKeyDown);

            }

            let rowElement = createRow(id, label, inputElement).rowElement;

            return {inputElement, rowElement};

        }

        this._nameInputElement = createInputRow("name", WI.UIString("Name"), "text", data.name).inputElement;

        this._valueInputElement = createInputRow("value", WI.UIString("Value"), "text", data.value).inputElement;

        this._domainInputElement = createInputRow("domain", WI.unlocalizedString("Domain"), "text", data.domain).inputElement;

        this._pathInputElement = createInputRow("path", WI.unlocalizedString("Path"), "text", data.path).inputElement;

        this._sessionCheckboxElement = createInputRow("session", WI.unlocalizedString("Session"), "checkbox", data.session).inputElement;

        let expiresInputRow = createInputRow("expires", WI.unlocalizedString("Expires"), "datetime-local", data.expires);

        this._expiresInputElement = expiresInputRow.inputElement;

        this._expiresInputElement.addEventListener("input", (event) => {

            this._expiresInputElement.classList.toggle("invalid", isNaN(this._parseExpires()));

        });

        this._httpOnlyCheckboxElement = createInputRow("http-only", WI.unlocalizedString("HttpOnly"), "checkbox", data.httpOnly).inputElement;

        this._secureCheckboxElement = createInputRow("secure", WI.unlocalizedString("Secure"), "checkbox", data.secure).inputElement;

        this._sameSiteSelectElement = document.createElement("select");

        for (let sameSiteType of Object.values(WI.Cookie.SameSiteType)) {

            let optionElement = this._sameSiteSelectElement.appendChild(document.createElement("option"));

            optionElement.textContent = sameSiteType;

        }

        createRow("same-site", WI.unlocalizedString("SameSite"), this._sameSiteSelectElement);

        let toggleExpiresRow = () => {

            expiresInputRow.rowElement.hidden = this._sessionCheckboxElement.checked;

            this.update();

        };

        this._sessionCheckboxElement.addEventListener("change", (event) => {

            toggleExpiresRow();

        });

        toggleExpiresRow();

        this._serializedDataWhenShown = this.serializedData;

        this.content = popoverContentElement;

        this._presentOverTargetElement();

    }

    // Private

    _presentOverTargetElement()

    {

        if (!this._targetElement)

            return;

        let targetFrame = WI.Rect.rectFromClientRect(this._targetElement.getBoundingClientRect());

        this.present(targetFrame.pad(2), this._preferredEdges);

    }

    _defaultExpires()

    {

        return new Date(Date.now() + (1000 * 60 * 60 * 24)); // one day in the future

    }

    _parseExpires()

    {

        let timestamp = Date.parse(this._expiresInputElement.value || this._expiresInputElement.placeholder);

        if (timestamp < Date.now())

            return NaN;

        return timestamp;

    }

    _handleInputKeyDown(event)

    {

        if (event.key === "Enter" || event.key === "Esc")

            this.dismiss();

    }

};

        if (InspectorBackend.hasCommand("Page.setCookie")) {

            this._setCookieButtonNavigationItem = new WI.ButtonNavigationItem("cookie-storage-set-cookie", WI.UIString("Add Cookie"), "Images/Plus15.svg", 15, 15);

            this._setCookieButtonNavigationItem.addEventListener(WI.ButtonNavigationItem.Event.Clicked, this._handleSetCookieButtonClick, this);

        }

        if (InspectorBackend.hasCommand("Page.setCookie")) {

            contextMenu.appendItem(WI.UIString("Edit"), () => {

                console.assert(!this._editingCookie);

                this._editingCookie = this._cookies[rowIndex];

                let popover = new WI.CookiePopover(this);

                popover.show(this._editingCookie, this._table.cellForRowAndColumn(rowIndex, this._table.columns[0]), [WI.RectEdge.MAX_Y, WI.RectEdge.MIN_X]);

            });

        }

    // Popover delegate

    willDismissPopover(popover)

    {

        if (popover instanceof WI.CookiePopover) {

            this._willDismissCookiePopover(popover);

            return;

        }

        console.assert();

    }

    async _willDismissCookiePopover(popover)

    {

        let editingCookie = this._editingCookie;

        this._editingCookie = null;

        let serializedData = popover.serializedData;

        if (!serializedData) {

            InspectorFrontendHost.beep();

            return;

        }

        let cookieToSet = WI.Cookie.fromPayload(serializedData);

        let cookieProtocolPayload = cookieToSet.toProtocol();

        if (!cookieProtocolPayload) {

            InspectorFrontendHost.beep();

            return;

        }

        let target = WI.assumingMainTarget();

        let promises = [];

        if (editingCookie)

            promises.push(target.PageAgent.deleteCookie(editingCookie.name, editingCookie.url));

        promises.push(target.PageAgent.setCookie(cookieProtocolPayload));

        promises.push(this._reloadCookies());

        await Promise.all(promises);

        let index = this._cookies.findIndex((existingCookie) => cookieToSet.equals(existingCookie));

        if (index >= 0)

            this._table.selectRow(index);

    }

    _handleSetCookieButtonClick(event)

    {

        let popover = new WI.CookiePopover(this);

        popover.show(null, this._setCookieButtonNavigationItem.element, [WI.RectEdge.MAX_Y, WI.RectEdge.MIN_X]);

    }

void NetworkConnectionToWebProcess::setRawCookie(const WebCore::Cookie& cookie)

{

    auto* networkStorageSession = storageSession();

    if (!networkStorageSession)

        return;

    networkStorageSession->setCookie(cookie);

}

    void setRawCookie(const WebCore::Cookie&);

    SetRawCookie(struct WebCore::Cookie cookie)

void WebCookieJar::setRawCookie(const WebCore::Document& document, const Cookie& cookie)

{

    WebProcess::singleton().ensureNetworkProcessConnection().connection().send(Messages::NetworkConnectionToWebProcess::SetRawCookie(cookie), 0);

}

    void setRawCookie(const WebCore::Document&, const WebCore::Cookie&) final;

2020-03-20  Devin Rousso  <drousso@apple.com>

        Web Inspector: support editing cookie key/values from inspector

        https://bugs.webkit.org/show_bug.cgi?id=31157

        <rdar://problem/19281523>

        Reviewed by NOBODY (OOPS!).

        * http/tests/inspector/page/setCookie.html: Added.

        * http/tests/inspector/page/setCookie-expected.txt: Added.

        * inspector/unit-tests/number-utilities.html:

        * inspector/unit-tests/number-utilities-expected.txt:

        Drive-by: add tests for `Number.prototype.maxDecimals`.

Test for the Page.setCookie.

== Running test suite: Page.setCookie

-- Running test case: Page.setCookie.Valid

PASS: Should have been able to set all cookies.

-- Running test case: Page.setCookie.Invalid

Setting cookie {} ...

PASS: Should produce an exception.

Error: Invalid value for key name in given cookie

Setting cookie {"name":null} ...

PASS: Should produce an exception.

Error: Invalid value for key name in given cookie

Setting cookie {"name":-1} ...

PASS: Should produce an exception.

Error: Invalid value for key name in given cookie

Setting cookie {"name":"name"} ...

PASS: Should produce an exception.

Error: Invalid value for key value in given cookie

Setting cookie {"name":"name","value":null} ...

PASS: Should produce an exception.

Error: Invalid value for key value in given cookie

Setting cookie {"name":"name","value":-1} ...

PASS: Should produce an exception.

Error: Invalid value for key value in given cookie

Setting cookie {"name":"name","value":"value"} ...

PASS: Should produce an exception.

Error: Invalid value for key domain in given cookie

Setting cookie {"name":"name","value":"value","domain":null} ...

PASS: Should produce an exception.

Error: Invalid value for key domain in given cookie

Setting cookie {"name":"name","value":"value","domain":-1} ...

PASS: Should produce an exception.

Error: Invalid value for key domain in given cookie

Setting cookie {"name":"name","value":"value","domain":"webkit.org"} ...

PASS: Should produce an exception.

Error: Invalid value for key path in given cookie

Setting cookie {"name":"name","value":"value","domain":"webkit.org","path":null} ...

PASS: Should produce an exception.

Error: Invalid value for key path in given cookie

Setting cookie {"name":"name","value":"value","domain":"webkit.org","path":-1} ...

PASS: Should produce an exception.

Error: Invalid value for key path in given cookie

Setting cookie {"name":"name","value":"value","domain":"webkit.org","path":"/"} ...

PASS: Should produce an exception.

Error: Invalid value for key httpOnly in given cookie

Setting cookie {"name":"name","value":"value","domain":"webkit.org","path":"/","expires":null} ...

PASS: Should produce an exception.

Error: Invalid value for key httpOnly in given cookie

Setting cookie {"name":"name","value":"value","domain":"webkit.org","path":"/","expires":"INVALID"} ...

PASS: Should produce an exception.

Error: Invalid value for key httpOnly in given cookie

Setting cookie {"name":"name","value":"value","domain":"webkit.org","path":"/","expires":10000000000} ...

PASS: Should produce an exception.

Error: Invalid value for key httpOnly in given cookie

Setting cookie {"name":"name","value":"value","domain":"webkit.org","path":"/","expires":10000000000,"session":null} ...

PASS: Should produce an exception.

Error: Invalid value for key httpOnly in given cookie

Setting cookie {"name":"name","value":"value","domain":"webkit.org","path":"/","expires":10000000000,"session":"INVALID"} ...

PASS: Should produce an exception.

Error: Invalid value for key httpOnly in given cookie

Setting cookie {"name":"name","value":"value","domain":"webkit.org","path":"/","expires":10000000000,"session":true} ...

PASS: Should produce an exception.

Error: Invalid value for key httpOnly in given cookie

Setting cookie {"name":"name","value":"value","domain":"webkit.org","path":"/","expires":10000000000,"session":true,"httpOnly":null} ...

PASS: Should produce an exception.

Error: Invalid value for key httpOnly in given cookie

Setting cookie {"name":"name","value":"value","domain":"webkit.org","path":"/","expires":10000000000,"session":true,"httpOnly":"INVALID"} ...

PASS: Should produce an exception.

Error: Invalid value for key httpOnly in given cookie

Setting cookie {"name":"name","value":"value","domain":"webkit.org","path":"/","expires":10000000000,"session":true,"httpOnly":true} ...

PASS: Should produce an exception.

Error: Invalid value for key secure in given cookie

Setting cookie {"name":"name","value":"value","domain":"webkit.org","path":"/","expires":10000000000,"session":true,"httpOnly":true,"secure":null} ...

PASS: Should produce an exception.

Error: Invalid value for key secure in given cookie

Setting cookie {"name":"name","value":"value","domain":"webkit.org","path":"/","expires":10000000000,"session":true,"httpOnly":true,"secure":"INVALID"} ...

PASS: Should produce an exception.

Error: Invalid value for key secure in given cookie

Setting cookie {"name":"name","value":"value","domain":"webkit.org","path":"/","expires":10000000000,"session":true,"httpOnly":true,"secure":true} ...

PASS: Should produce an exception.

Error: Invalid value for key sameSite in given cookie

Setting cookie {"name":"name","value":"value","domain":"webkit.org","path":"/","expires":10000000000,"session":true,"httpOnly":true,"secure":true,"sameSite":null} ...

PASS: Should produce an exception.

Error: Invalid value for key sameSite in given cookie

Setting cookie {"name":"name","value":"value","domain":"webkit.org","path":"/","expires":10000000000,"session":true,"httpOnly":true,"secure":true,"sameSite":-1} ...

PASS: Should produce an exception.

Error: Invalid value for key sameSite in given cookie

Setting cookie {"name":"name","value":"value","domain":"webkit.org","path":"/","expires":10000000000,"session":true,"httpOnly":true,"secure":true,"sameSite":"INVALID"} ...

PASS: Should produce an exception.

Error: Invalid value for key sameSite in given cookie

<!DOCTYPE html>

<html>

<head>

<script src="../resources/inspector-test.js"></script>

<script>

if (window.testRunner)

    testRunner.setAlwaysAcceptCookies(true);

function test()

{

    const millisecondsPerDay = 1000 * 60 * 60 * 24;

    let tomorrow = new Date(Date.now().maxDecimals(-3) + millisecondsPerDay);

    let suite = InspectorTest.createAsyncSuite("Page.setCookie");

    suite.addTestCase({

        name: "Page.setCookie.Valid",

        description: "Check that setting a valid cookies works.",

        async test() {

            let cookiesToSet = [

                {

                    expires: tomorrow,

                    session: false,

                    path: "/",

                    domain: "127.0.0.1",

                    secure: false,

                    httpOnly: false,

                    sameSite: WI.Cookie.SameSiteType.Lax,

                },

                {

                    expires: tomorrow,

                    session: true,

                    path: "/inspector/",

                    domain: "127.0.0.1",

                    secure: true,

                    httpOnly: true,

                    sameSite: WI.Cookie.SameSiteType.Strict,

                },

            ].map((options, i) => new WI.Cookie(WI.Cookie.Type.Response, "TestCookieName" + i, "TestCookieValue" + i, options));

            for (let cookieToSet of cookiesToSet)

                await PageAgent.setCookie(cookieToSet.toProtocol());

            let getCookiesResult = await PageAgent.getCookies();

            let setCookies = getCookiesResult.cookies.map(WI.Cookie.fromPayload);

            let found = true;

            for (let cookieToSet of cookiesToSet) {

                if (!setCookies.find((setCookie) => cookieToSet.equals(setCookie))) {

                    found = false;

                    InspectorTest.fail("Missing cookie:");

                    InspectorTest.json(cookieToSet);

                }

            }

            InspectorTest.expectTrue(found, "Should have been able to set all cookies.");

        },

    });

    suite.addTestCase({

        name: "Page.setCookie.Invalid",

        description: "Check that the PageAgent correctly parses the given cookie JSON object.",

        async test() {

            const invalidValue = null;

            const invalidString = -1;

            const invalidNumber = "INVALID";

            const invalidBoolean = invalidNumber;

            const cookies = [

                {},

                {name: invalidValue},

                {name: invalidString},

                {name: "name"},

                {name: "name", value: invalidValue},

                {name: "name", value: invalidString},

                {name: "name", value: "value"},

                {name: "name", value: "value", domain: invalidValue},

                {name: "name", value: "value", domain: invalidString},

                {name: "name", value: "value", domain: "webkit.org"},

                {name: "name", value: "value", domain: "webkit.org", path: invalidValue},

                {name: "name", value: "value", domain: "webkit.org", path: invalidString},

                {name: "name", value: "value", domain: "webkit.org", path: "/"},

                {name: "name", value: "value", domain: "webkit.org", path: "/", expires: invalidValue},

                {name: "name", value: "value", domain: "webkit.org", path: "/", expires: invalidNumber},

                {name: "name", value: "value", domain: "webkit.org", path: "/", expires: 10000000000},

                {name: "name", value: "value", domain: "webkit.org", path: "/", expires: 10000000000, session: invalidValue},

                {name: "name", value: "value", domain: "webkit.org", path: "/", expires: 10000000000, session: invalidBoolean},

                {name: "name", value: "value", domain: "webkit.org", path: "/", expires: 10000000000, session: true},

                {name: "name", value: "value", domain: "webkit.org", path: "/", expires: 10000000000, session: true, httpOnly: invalidValue},

                {name: "name", value: "value", domain: "webkit.org", path: "/", expires: 10000000000, session: true, httpOnly: invalidBoolean},

                {name: "name", value: "value", domain: "webkit.org", path: "/", expires: 10000000000, session: true, httpOnly: true},

                {name: "name", value: "value", domain: "webkit.org", path: "/", expires: 10000000000, session: true, httpOnly: true, secure: invalidValue},

                {name: "name", value: "value", domain: "webkit.org", path: "/", expires: 10000000000, session: true, httpOnly: true, secure: invalidBoolean},

                {name: "name", value: "value", domain: "webkit.org", path: "/", expires: 10000000000, session: true, httpOnly: true, secure: true},

                {name: "name", value: "value", domain: "webkit.org", path: "/", expires: 10000000000, session: true, httpOnly: true, secure: true, sameSite: invalidValue},

                {name: "name", value: "value", domain: "webkit.org", path: "/", expires: 10000000000, session: true, httpOnly: true, secure: true, sameSite: invalidString},

                {name: "name", value: "value", domain: "webkit.org", path: "/", expires: 10000000000, session: true, httpOnly: true, secure: true, sameSite: "INVALID"},

            ];

            for (let cookie of cookies) {

                InspectorTest.log("Setting cookie " + JSON.stringify(cookie) + " ...");

                await InspectorTest.expectException(() => PageAgent.setCookie(cookie));

                InspectorTest.newline();

            }

        },

    });

    suite.runTestCasesAndFinish();

}

</script>

</head>

<body onload="runTestHTTPS()">

    <p>Test for the Page.setCookie.</p>

</body>

</html>

-- Running test case: Number.prototype.maxDecimals

PASS: maxDecimals with a negative argument more than the number of digits should be 0

PASS: maxDecimals with a negative argument more equal to the number of digits should be 0

PASS: maxDecimals with -2 should truncate that 2 units in front of the decimal

PASS: maxDecimals with -1 should truncate that 1 units in front of the decimal

PASS: maxDecimals with 0 should round the value

PASS: maxDecimals with 1 should round after the 1st decimal

PASS: maxDecimals with 2 should round after the 2nd decimal

PASS: maxDecimals with a positive argument equal to the number of digits should not modify the number

PASS: maxDecimals with a positive argument greater than the number of digits should not modify the number

    suite.addTestCase({

        name: "Number.prototype.maxDecimals",

        test() {

            const n = 123.456;

            InspectorTest.expectEqual(n.maxDecimals(-4), 0, "maxDecimals with a negative argument more than the number of digits should be 0");

            InspectorTest.expectEqual(n.maxDecimals(-3), 0, "maxDecimals with a negative argument more equal to the number of digits should be 0");

            InspectorTest.expectEqual(n.maxDecimals(-2), 100, "maxDecimals with -2 should truncate that 2 units in front of the decimal");

            InspectorTest.expectEqual(n.maxDecimals(-1), 120, "maxDecimals with -1 should truncate that 1 units in front of the decimal");

            InspectorTest.expectEqual(n.maxDecimals(0), 123, "maxDecimals with 0 should round the value");

            InspectorTest.expectEqual(n.maxDecimals(1), 123.5, "maxDecimals with 1 should round after the 1st decimal");

            InspectorTest.expectEqual(n.maxDecimals(2), 123.46, "maxDecimals with 2 should round after the 2nd decimal");

            InspectorTest.expectEqual(n.maxDecimals(3), 123.456, "maxDecimals with a positive argument equal to the number of digits should not modify the number");

            InspectorTest.expectEqual(n.maxDecimals(4), 123.456, "maxDecimals with a positive argument greater than the number of digits should not modify the number");

        },

    });