Attachment #291255 for bug #163249

View Details Raw Unified Return to Bug 163249

| Differences between



2016-10-11  Antoine Quint  <graouts@apple.com>

        [mac] LayoutTest media/modern-media-controls/play-pause-button/play-pause-button.html is a flaky failure
        https://bugs.webkit.org/show_bug.cgi?id=163249

        Reviewed by Antoine Quint.

        Wait until all icon images are loaded before running the assertions. We can determine whether
        a button's icon image is loaded by checking it's been sized.

        * TestExpectations:
        * media/modern-media-controls/play-pause-button/play-pause-button.html:

2016-10-11  Antoine Quint  <graouts@apple.com>

        [mac] LayoutTest media/modern-media-controls/airplay-button/airplay-button.html is a flaky failure
        https://bugs.webkit.org/show_bug.cgi?id=163248


Lines 986-989 webkit.org/b/162414 imported/w3c/web-platform-tests/resource-timing/idlharness.h a/LayoutTests/TestExpectations_sec1
- a/LayoutTests/TestExpectations -1 lines
986	# Only iOS has implemented lettepress.	986	# Only iOS has implemented lettepress.
987	fast/text/letterpress-different.html [ ImageOnlyFailure ]	987	fast/text/letterpress-different.html [ ImageOnlyFailure ]
988		988
989	webkit.org/b/163249 media/modern-media-controls/play-pause-button/play-pause-button.html [ Failure ]

Lines 41-46 iOSPauseButton.playing = true; a/LayoutTests/media/modern-media-controls/play-pause-button/play-pause-button.html_sec1
- a/LayoutTests/media/modern-media-controls/play-pause-button/play-pause-button.html +3 lines
41		41
42	scheduler.frameDidFire = function()	42	scheduler.frameDidFire = function()
43	{	43	{
		44	if ([playButton, pauseButton, iOSPlayButton, iOSPauseButton, fullscreenPlayButton, fullscreenPauseButton].some(button => button.width == 0))
		45	return;
		46
44	shouldBeTrue('playButton.element.style.webkitMaskImage.includes("macOS/play@")');	47	shouldBeTrue('playButton.element.style.webkitMaskImage.includes("macOS/play@")');
45	shouldBeTrue('pauseButton.element.style.webkitMaskImage.includes("macOS/pause@")');	48	shouldBeTrue('pauseButton.element.style.webkitMaskImage.includes("macOS/pause@")');
46	shouldBeTrue('iOSPlayButton.element.style.webkitMaskImage.includes("iOS/play@")');	49	shouldBeTrue('iOSPlayButton.element.style.webkitMaskImage.includes("iOS/play@")');

Return to Bug 163249

Lines 1-5 a/LayoutTests/ChangeLog_sec1
- a/LayoutTests/ChangeLog +13 lines
1	2016-10-11 Antoine Quint <graouts@apple.com>	1	2016-10-11 Antoine Quint <graouts@apple.com>
2		2
		3	[mac] LayoutTest media/modern-media-controls/play-pause-button/play-pause-button.html is a flaky failure
		4	https://bugs.webkit.org/show_bug.cgi?id=163249
		5
		6	Reviewed by Antoine Quint.
		7
		8	Wait until all icon images are loaded before running the assertions. We can determine whether
		9	a button's icon image is loaded by checking it's been sized.
		10
		11	* TestExpectations:
		12	* media/modern-media-controls/play-pause-button/play-pause-button.html:
		13
		14	2016-10-11 Antoine Quint <graouts@apple.com>
		15
3	[mac] LayoutTest media/modern-media-controls/airplay-button/airplay-button.html is a flaky failure	16	[mac] LayoutTest media/modern-media-controls/airplay-button/airplay-button.html is a flaky failure
4	https://bugs.webkit.org/show_bug.cgi?id=163248	17	https://bugs.webkit.org/show_bug.cgi?id=163248
5		18