| Differences between
and this patch
- a/Tools/ChangeLog +10 lines
Lines 1-3 a/Tools/ChangeLog_sec1
1
2012-05-16  Balazs Ankes  <bank@inf.u-szeged.hu>
2
3
        webkit-patch should add reviewer if "Reviewed by NOBODY (OOPS!)." is missing
4
        https://bugs.webkit.org/show_bug.cgi?id=67935
5
6
        Reviewed by NOBODY (OOPS!).
7
8
        * Scripts/webkitpy/common/checkout/changelog.py:
9
        (ChangeLog.set_reviewer):
10
1
2012-05-15  Pierre Rossi  <pierre.rossi@gmail.com>
11
2012-05-15  Pierre Rossi  <pierre.rossi@gmail.com>
2
12
3
        [Qt] Enable SVG Fonts by default
13
        [Qt] Enable SVG Fonts by default
- a/Tools/Scripts/webkitpy/common/checkout/changelog.py -4 / +18 lines
Lines 341-350 class ChangeLog(object): a/Tools/Scripts/webkitpy/common/checkout/changelog.py_sec1
341
                print line,
341
                print line,
342
342
343
    def set_reviewer(self, reviewer):
343
    def set_reviewer(self, reviewer):
344
        # inplace=1 creates a backup file and re-directs stdout to the file
344
        latest_entry = self.latest_entry()._contents
345
        for line in fileinput.FileInput(self.path, inplace=1):
345
        found_reviewer = re.search(".*NOBODY\s*\(OOPS!\).*", latest_entry, re.MULTILINE)
346
            # Trailing comma suppresses printing newline
346
347
            print line.replace("NOBODY (OOPS!)", reviewer.encode("utf-8")),
347
        if found_reviewer:
348
            # inplace=1 creates a backup file and re-directs stdout to the file
349
            for line in fileinput.FileInput(self.path, inplace=1):
350
                # Trailing comma suppresses printing newline
351
                print line.replace("NOBODY (OOPS!)", reviewer.encode("utf-8")),
352
        else:
353
            latest_entry = True
354
            bug_url_regexp = 'https://bugs.webkit.org/show_bug.cgi\?id='
355
356
            for line in fileinput.FileInput(self.path, inplace=1):
357
                found_bug_url = re.search(bug_url_regexp, line)
358
                print line,
359
                if found_bug_url and latest_entry:
360
                    print "\n        Reviewed by " + reviewer.encode("utf-8"),
361
                    latest_entry = False
348
362
349
    def set_short_description_and_bug_url(self, short_description, bug_url):
363
    def set_short_description_and_bug_url(self, short_description, bug_url):
350
        message = "%s\n        %s" % (short_description, bug_url)
364
        message = "%s\n        %s" % (short_description, bug_url)

Return to Bug 67935